Add parameter forceDismiss to dismissActiveNotification method #113
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to dismiss the message even if it is not fully displayed
dennisreimann
added a commit
that referenced
this pull request
Feb 23, 2014
Thanks for the contribution @azrle. I had to reimplement the functionality because of the extensive changes we made meanwhile when working on 1.0
|
@dennisreimann Thanks for migrating the changes to the current develop branch. We could merge this PR and release one last version before 1.0 that features this PR and also the default behaviour of tap to dismiss |
|
I handle this merge request for supporting the 0.X Version as long as we can. |
LukeDurrant
added a commit
to LukeDurrant/TSMessages
that referenced
this pull request
Mar 29, 2015
* upstream/develop: (27 commits) Add swipe callback Also set swipe direction when setting position Improve check for hidden navigationbar Fix case where there is no navigation controller Reimplement forcing message dismissal as in KrauseFx#113 Change delegation method to define custom offset Change userDismissEnabled and make it default * Updated alternative design file to fit iOS 7 style Improved shadow color of text in alternativeDesign.json Fix naming I oversaw Improve interface with convenience methods Update README Consolidate naming Remove unused defines Use dispatch_once for singleton initialization Remove state variable Remove xccheckout file from repository Move custom design handling to TSMessage class Rename showOrEnqueueNotification method Refactor initializers ... Conflicts: Example/TSMessages.xcworkspace/xcshareddata/TSMessages.xccheckout Example/TSMessages/Base.lproj/Main_iPhone.storyboard Example/TSMessages/TSDemoViewController.h Example/TSMessages/TSDemoViewController.m ExampleProject/Example.xcodeproj/project.pbxproj ExampleProject/Pods/Local Podspecs/TSMessages.podspec ExampleProject/Pods/Pods-resources.sh ExampleProject/Pods/Pods.xcodeproj/project.pbxproj Pod/Assets/NotificationBackgroundError.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundErrorIcon.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundMessage.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundSuccess.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundSuccessIcon.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundWarning.png Pod/Assets/[email protected] Pod/Assets/NotificationBackgroundWarningIcon.png Pod/Assets/[email protected] Pod/Assets/NotificationButtonBackground.png Pod/Assets/[email protected] Pod/Classes/TSMessage.m Pod/Classes/TSMessageView.m README.md TSMessages.podspec TSMessages/Classes/TSMessage.h TSMessages/Resources/Images/MessageBackgroundDefault.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundError.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundErrorIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundSuccess.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundSuccessIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundWarning.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageBackgroundWarningIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/MessageButtonBackground.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundError.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundErrorIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundMessage.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundSuccess.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundSuccessIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundWarning.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationBackgroundWarningIcon.png TSMessages/Resources/Images/[email protected] TSMessages/Resources/Images/NotificationButtonBackground.png TSMessages/Resources/Images/[email protected] TSMessages/Views/TSMessageView.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
+ (BOOL)dismissActiveNotification:(BOOL)forceDismissmethod in order to dismiss the message even if it is not fully displayed.Here is the use case.
We first display a message showing that we are loading data, and then data comes before the animation has finished. At this moment, we want to force it to dismiss the loading message even if it is not fully displayed.